[styled-engine-sc] Fix types for components extended with styled #45988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45988--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
@megos How did you test this? I updated @mui/material to this PR build:
- "@mui/material": "latest",
+ "@mui/material": "https://pkg.pr.new/mui/material-ui/@mui/material@0ea7b86",in this StackBlitz: https://stackblitz.com/edit/vitejs-vite-tggt1unx — but TypeScript isn’t throwing any error for Button2.
Edit: Oh, I had to replace @mui/styled-engine-sc version to point to this PR build and it works! Ignore above message.
|
@mnajdova Can you review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44246
Improve type support for passing a styled component as an argument to styled.
Before: https://stackblitz.com/edit/vitejs-vite-afbuyz?file=src%2FApp.tsx&view=editor
After: https://stackblitz.com/edit/vitejs-vite-tggt1unx