Fix "Climbing over certain objects kills you" #4395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #602
A ped is killed by excessive fall speed. CPed::ProcessEntityCollision applies damage when the ped’s Z-axis velocity is less than a defined value: -0.375. With high FPS (>74) or low game speed, this fall velocity becomes greater (the value becomes smaller) due to timeStep.
CTaskSimpleClimb sets the Z-axis velocity based on timeStep; specifically, it calculates a multiplier from 1 / timeStep, which produces high numbers for small values (e.g. 1 / 0.2 = 5). The solution is to set a fixed timeStep in this case.
I tested several locations on the map and did not observe the same issues as @lopezloo reported in his PR.