Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -350,6 +362,8 @@ void DataChannelWrapper::onClosed(const Napi::CallbackInfo &info) | |||
| // This will run in main thread and needs to construct the | |||
| // arguments for the call | |||
| args = {}; | |||
| },[this]{ | |||
| doCleanup(); | |||
There was a problem hiding this comment.
If I'm not mistaken, doCleanup() won't be called if the user did not set a closed callback.
| callback.Call(context->Value(), args); | ||
| cleanup(); |
There was a problem hiding this comment.
I think cleanup() should be called anyway, even if env or callback are not set, otherwise there could be scenarios where cleanup is never done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #236