fix: polyfill W3C compatibility

package.json

@@ -79,6 +79,7 @@
         "@rollup/plugin-replace": "^6.0.1",
         "@types/jest": "^29.5.12",
         "@types/node": "^20.6.1",
+        "@types/webrtc": "^0.0.44",
         "@typescript-eslint/eslint-plugin": "^7.17.0",
         "@typescript-eslint/parser": "^7.17.0",
         "cmake-js": "^7.3.0",
@@ -104,4 +105,4 @@
     "dependencies": {
         "prebuild-install": "^7.1.2"
     }
-}
+}

src/polyfill/Events.ts

@@ -14,20 +14,63 @@ export class RTCPeerConnectionIceEvent extends Event implements globalThis.RTCPe
     get candidate(): RTCIceCandidate {
         return this.#candidate;
     }
+
+    get url (): string {
+        return '' // TODO ?
+    }
 }
 
 export class RTCDataChannelEvent extends Event implements globalThis.RTCDataChannelEvent {
     #channel: RTCDataChannel;
 
-    constructor(type: string, eventInitDict: globalThis.RTCDataChannelEventInit) {
-        super(type);
+    // type is defined as a consturctor, but always overwritten, interesting spec
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    constructor(_type: string = 'datachannel', init: globalThis.RTCDataChannelEventInit) {
+        if (arguments.length === 0) throw new TypeError(`Failed to construct 'RTCDataChannelEvent': 2 arguments required, but only ${arguments.length} present.`)
+        if (typeof init !== 'object') throw new TypeError("Failed to construct 'RTCDataChannelEvent': The provided value is not of type 'RTCDataChannelEventInit'.")
+        if (!init.channel) throw new TypeError("Failed to construct 'RTCDataChannelEvent': Failed to read the 'channel' property from 'RTCDataChannelEventInit': Required member is undefined.")
+        if (init.channel.constructor !== RTCDataChannel) throw new TypeError("Failed to construct 'RTCDataChannelEvent': Failed to read the 'channel' property from 'RTCDataChannelEventInit': Failed to convert value to 'RTCDataChannel'.")
+        super('datachannel')
 
-        if (type && !eventInitDict.channel) throw new TypeError('channel member is required');
-
-        this.#channel = eventInitDict?.channel as RTCDataChannel;
+        this.#channel = init.channel;
     }
 
     get channel(): RTCDataChannel {
         return this.#channel;
     }
 }
+
+export class RTCErrorEvent extends Event implements globalThis.RTCErrorEvent {
+    #error: RTCError
+    constructor (type: string, init: globalThis.RTCErrorEventInit) {
+        if (arguments.length < 2) throw new TypeError(`Failed to construct 'RTCErrorEvent': 2 arguments required, but only ${arguments.length} present.`)
+        if (typeof init !== 'object') throw new TypeError("Failed to construct 'RTCErrorEvent': The provided value is not of type 'RTCErrorEventInit'.")
+        if (!init.error) throw new TypeError("Failed to construct 'RTCErrorEvent': Failed to read the 'error' property from 'RTCErrorEventInit': Required member is undefined.")
+        if (init.error.constructor !== RTCError) throw new TypeError("Failed to construct 'RTCErrorEvent': Failed to read the 'error' property from 'RTCErrorEventInit': Failed to convert value to 'RTCError'.")
+        super(type || 'error')
+        this.#error = init.error
+    }
+
+    get error (): RTCError {
+        return this.#error
+    }
+}
+
+export class MediaStreamTrackEvent extends Event implements globalThis.MediaStreamTrackEvent {
+    #track: MediaStreamTrack
+
+    constructor (type, init) {
+        if (arguments.length === 0) throw new TypeError(`Failed to construct 'MediaStreamTrackEvent': 2 arguments required, but only ${arguments.length} present.`)
+        if (typeof init !== 'object') throw new TypeError("Failed to construct 'MediaStreamTrackEvent': The provided value is not of type 'MediaStreamTrackEventInit'.")
+        if (!init.track) throw new TypeError("Failed to construct 'MediaStreamTrackEvent': Failed to read the 'track' property from 'MediaStreamTrackEventInit': Required member is undefined.")
+        if (init.track.constructor !== MediaStreamTrack) throw new TypeError("Failed to construct 'MediaStreamTrackEvent': Failed to read the 'channel' property from 'MediaStreamTrackEventInit': Failed to convert value to 'RTCDataChannel'.")
+
+        super(type)
+
+        this.#track = init.track
+    }
+
+    get track (): MediaStreamTrack {
+        return this.#track
+    }
+}

src/polyfill/RTCCertificate.ts

@@ -14,4 +14,8 @@ export default class RTCCertificate implements globalThis.RTCCertificate {
     getFingerprints(): globalThis.RTCDtlsFingerprint[] {
         return this.#fingerprints;
     }
+
+    getAlgorithm (): string {
+        return ''
+    }
 }

src/polyfill/RTCDataChannel.ts

@@ -1,57 +1,60 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import * as exceptions from './Exception';
 import { DataChannel } from '../lib/index';
+import RTCPeerConnection from './RTCPeerConnection';
+import { RTCErrorEvent } from './Events';
 
 export default class RTCDataChannel extends EventTarget implements globalThis.RTCDataChannel {
     #dataChannel: DataChannel;
     #readyState: RTCDataChannelState;
-    #bufferedAmountLowThreshold: number;
-    #binaryType: BinaryType;
+    #bufferedAmountLowThreshold: number = 0;
+    #binaryType: BinaryType = 'blob';
     #maxPacketLifeTime: number | null;
     #maxRetransmits: number | null;
     #negotiated: boolean;
     #ordered: boolean;
-
-    #closeRequested = false;
+    #pc: RTCPeerConnection;
 
     // events
-    onbufferedamountlow: ((this: RTCDataChannel, ev: Event) => any) | null;
-    onclose: ((this: RTCDataChannel, ev: Event) => any) | null;
-    onclosing: ((this: RTCDataChannel, ev: Event) => any) | null;
-    onerror: ((this: RTCDataChannel, ev: Event) => any) | null;
-    onmessage: ((this: RTCDataChannel, ev: MessageEvent) => any) | null;
-    onopen: ((this: RTCDataChannel, ev: Event) => any) | null;
-
-    constructor(dataChannel: DataChannel, opts: globalThis.RTCDataChannelInit = {}) {
+    onbufferedamountlow: globalThis.RTCDataChannel['onbufferedamountlow'];
+    onclose: globalThis.RTCDataChannel['onclose'];
+    onclosing: globalThis.RTCDataChannel['onclosing'];
+    onerror: globalThis.RTCDataChannel['onerror'];
+    onmessage: globalThis.RTCDataChannel['onmessage'];
+    onopen: globalThis.RTCDataChannel['onopen']
+
+    constructor(dataChannel: DataChannel, opts: globalThis.RTCDataChannelInit = {}, pc: RTCPeerConnection) {
         super();
 
         this.#dataChannel = dataChannel;
-        this.#binaryType = 'blob';
         this.#readyState = this.#dataChannel.isOpen() ? 'open' : 'connecting';
-        this.#bufferedAmountLowThreshold = 0;
-        this.#maxPacketLifeTime = opts.maxPacketLifeTime || null;
-        this.#maxRetransmits = opts.maxRetransmits || null;
-        this.#negotiated = opts.negotiated || false;
-        this.#ordered = opts.ordered || true;
+        this.#maxPacketLifeTime = opts.maxPacketLifeTime ?? null;
+        this.#maxRetransmits = opts.maxRetransmits ?? null;
+        this.#negotiated = opts.negotiated ?? false;
+        this.#ordered = opts.ordered ?? true;
+        this.#pc = pc
 
         // forward dataChannel events
         this.#dataChannel.onOpen(() => {
             this.#readyState = 'open';
             this.dispatchEvent(new Event('open', {}));
         });
 
-        this.#dataChannel.onClosed(() => {
-            // Simulate closing event
-            if (!this.#closeRequested) {
-                this.#readyState = 'closing';
-                this.dispatchEvent(new Event('closing'));
-            }
 
-            setImmediate(() => {
-                this.#readyState = 'closed';
-                this.dispatchEvent(new Event('close'));
-            });
-        });
+    // we need updated connectionstate, so this is delayed by a single event loop tick
+    // this is fucked and wonky, needs to be made better
+    this.#dataChannel.onClosed(() => setTimeout(() => {
+        if (this.#readyState !== 'closed') {
+          // this should be 'disconnected' but ldc doesn't support that
+        if (this.#pc.connectionState === 'closed') {
+            // if the remote connection suddently closes without closing dc first, throw this weird error
+            this.dispatchEvent(new RTCErrorEvent('error', { error: new RTCError({ errorDetail: 'sctp-failure', sctpCauseCode: 12 }, 'User-Initiated Abort, reason=Close called') }))
+        }
+        this.#readyState = 'closing'
+        this.dispatchEvent(new Event('closing'))
+        this.#readyState = 'closed'
+        }
+        this.dispatchEvent(new Event('close'))
+    }))
 
         this.#dataChannel.onError((msg) => {
             this.dispatchEvent(
@@ -70,16 +73,17 @@ export default class RTCDataChannel extends EventTarget implements globalThis.RT
             this.dispatchEvent(new Event('bufferedamountlow'));
         });
 
-        this.#dataChannel.onMessage((data) => {
-            if (ArrayBuffer.isView(data)) {
-                if (this.binaryType == 'arraybuffer')
-                    data = data.buffer;
-                else
-                    data = Buffer.from(data.buffer);
+        this.#dataChannel.onMessage(message => {
+            let data: Blob | ArrayBufferLike | string
+            if (!ArrayBuffer.isView(message)) {
+                data = message
+            } else if (this.#binaryType === 'blob') {
+                data = new Blob([message])
+            } else {
+                data = message.buffer
             }
-
-            this.dispatchEvent(new MessageEvent('message', { data }));
-        });
+            this.dispatchEvent(new MessageEvent('message', { data }))
+        })
 
         // forward events to properties
         this.addEventListener('message', (e) => {
@@ -89,7 +93,7 @@ export default class RTCDataChannel extends EventTarget implements globalThis.RT
             if (this.onbufferedamountlow) this.onbufferedamountlow(e);
         });
         this.addEventListener('error', (e) => {
-            if (this.onerror) this.onerror(e);
+            if (this.onerror) this.onerror(e as RTCErrorEvent);
         });
         this.addEventListener('close', (e) => {
             if (this.onclose) this.onclose(e);
@@ -162,7 +166,11 @@ export default class RTCDataChannel extends EventTarget implements globalThis.RT
         return this.#readyState;
     }
 
-    send(data): void {
+    get maxMessageSize (): number {
+        return this.#dataChannel.maxMessageSize()
+    }
+
+    send(data: string | Blob | ArrayBuffer | ArrayBufferView | Buffer): void {
         if (this.#readyState !== 'open') {
             throw new exceptions.InvalidStateError(
                 "Failed to execute 'send' on 'RTCDataChannel': RTCDataChannel.readyState is not 'open'",
@@ -171,26 +179,29 @@ export default class RTCDataChannel extends EventTarget implements globalThis.RT
 
         // Needs network error, type error implemented
         if (typeof data === 'string') {
+            if (data.length > this.#dataChannel.maxMessageSize()) throw new TypeError('Max message size exceeded.')
             this.#dataChannel.sendMessage(data);
-        } else if (data instanceof Blob) {
+        } else if ('arrayBuffer' in data) {
+            if (data.size > this.#dataChannel.maxMessageSize()) throw new TypeError('Max message size exceeded.')
             data.arrayBuffer().then((ab) => {
-                if (process?.versions?.bun) {
-                    this.#dataChannel.sendMessageBinary(Buffer.from(ab));
-                } else {
-                    this.#dataChannel.sendMessageBinary(new Uint8Array(ab));
-                }
+                this.#dataChannel.sendMessageBinary( process?.versions?.bun ? Buffer.from(ab) : new Uint8Array(ab));
             });
         } else {
-            if (process?.versions?.bun) {
-                this.#dataChannel.sendMessageBinary(Buffer.from(data));
-            } else {
-                this.#dataChannel.sendMessageBinary(new Uint8Array(data));
-            }
+            if (data.byteLength > this.#dataChannel.maxMessageSize()) throw new TypeError('Max message size exceeded.')
+            this.#dataChannel.sendMessageBinary( process?.versions?.bun ? Buffer.from(data as ArrayBuffer) : new Uint8Array(data as ArrayBuffer));
         }
     }
 
-    close(): void {
-        this.#closeRequested = true;
-        this.#dataChannel.close();
+    close (): void {
+        this.#readyState = 'closed'
+        setTimeout(() => {
+            if (this.#pc.connectionState === 'closed') {
+                // if the remote connection suddently closes without closing dc first, throw this weird error
+                // can this be done better?
+                this.dispatchEvent(new RTCErrorEvent('error', { error: new RTCError({ errorDetail: 'sctp-failure', sctpCauseCode: 12 }, 'User-Initiated Abort, reason=Close called') }))
+            }
+        })
+
+        this.#dataChannel.close()
     }
 }

src/polyfill/RTCDtlsTransport.ts

@@ -1,28 +1,24 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import RTCIceTransport from './RTCIceTransport';
 import RTCPeerConnection from './RTCPeerConnection';
 
 export default class RTCDtlsTransport extends EventTarget implements globalThis.RTCDtlsTransport {
     #pc: RTCPeerConnection = null;
     #iceTransport = null;
 
-    onstatechange: ((this: RTCDtlsTransport, ev: Event) => any) | null = null;
-    onerror: ((this: RTCDtlsTransport, ev: Event) => any) | null = null;
+    onstatechange: globalThis.RTCDtlsTransport['onstatechange'];
+    onerror: globalThis.RTCDtlsTransport['onstatechange'];
 
-    constructor(init: { pc: RTCPeerConnection, extraFunctions }) {
+    constructor({ pc }: { pc: RTCPeerConnection }) {
         super();
-        this.#pc = init.pc;
+        this.#pc = pc;
 
-        this.#iceTransport = new RTCIceTransport({ pc: init.pc, extraFunctions: init.extraFunctions });
+        this.#iceTransport = new RTCIceTransport({ pc });
 
         // forward peerConnection events
         this.#pc.addEventListener('connectionstatechange', () => {
-            this.dispatchEvent(new Event('statechange'));
-        });
-
-        // forward events to properties
-        this.addEventListener('statechange', (e) => {
-            if (this.onstatechange) this.onstatechange(e);
+            const e = new Event('statechange');
+            this.dispatchEvent(e);
+            this.onstatechange?.(e);
         });
     }
 
@@ -33,15 +29,12 @@ export default class RTCDtlsTransport extends EventTarget implements globalThis.
     get state(): RTCDtlsTransportState {
         // reduce state from new, connecting, connected, disconnected, failed, closed, unknown
         // to RTCDtlsTRansport states new, connecting, connected, closed, failed
-        let state = this.#pc ? this.#pc.connectionState : 'new';
-        if (state === 'disconnected') {
-            state = 'closed';
-        }
-        return state;
+        if (this.#pc.connectionState === 'disconnected') return 'closed'
+        return this.#pc.connectionState
     }
 
     getRemoteCertificates(): ArrayBuffer[] {
-        // TODO: implement
+        // TODO: implement, not supported by all browsers anyways
         return [new ArrayBuffer(0)];
     }
 }