Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent RTCDataChannel.close() from blocking the event loop #327

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix: prevent RTCDataChannel.close() from blocking the event loop #327

merged 1 commit into from
Jan 27, 2025

Conversation

mertushka
Copy link
Contributor

The RTCDataChannel.close() method now uses setImmediate to ensure it runs asynchronously, preventing the PeerConnection.close() method from blocking the event loop.

Fixes: #326

@mertushka mertushka mentioned this pull request Jan 27, 2025
Closed
@murat-dogan
Copy link
Owner

murat-dogan commented Jan 27, 2025 •
edited
Loading

Thanks for the fix

@murat-dogan murat-dogan merged commit b4934d0 into murat-dogan:master Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PeerConnection.close() Method is Blocking the Event Loop
2 participants
@mertushka @murat-dogan