fix: do not copy data before sending over datachannel #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single-arg constructor of `Uint8Array` copies the data from the passed arraylike. This can impact streaming performance in high traffic environments. Instead you can use the three-arg constructor or just pass the Uint8Array through if the arg satisfies that type.
achingbrain
force-pushed
the
fix/skip-copy-on-send
branch
from
1b05cc6 to
daba56f
Compare
|
Seems good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single-arg constructor of
Uint8Arraycopies the data from the passed arraylike.This can impact streaming performance in high traffic environments.
Instead you can use the three-arg constructor or just pass the
Uint8Arraythrough if the arg satisfies that type.