Twfy votes connections #1854
Open
Twfy votes connections #1854
+112
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
approved these changes
Feb 26, 2025
ajparsons
force-pushed
the
twfy-votes-connections
branch
from
55a258a to
b6475c6
Compare
|
Those are in! Will work out a good timeline to merge because this will now add the new votes content. |
Slightly different key names, and some differences in how agreements are stored.
- Signal sent after divisons are exported to import them to other site.
I don't think this should ever happen as why would you have a link to this page if they had no votes on a policy, but if that does happen then you get an error as the various has_strong/weak flags are defined inside the if and so not available when you get to the checks further down the page and trigger an error.
ajparsons
force-pushed
the
twfy-votes-connections
branch
from
b6475c6 to
986d00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic PR to connect to the new votes site rather than the prototype one.
Two changes:
This needs the config updated to the new votes site, the updater will say something but not fail if the refresh token isn't present.