-
Notifications
You must be signed in to change notification settings - Fork 22.1k
feat(core): Make detaching floatable entitlements on shutdown configurable #14266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing due to typecheck
Is this a breaking change? Can users be relying on a shorter or longer offset and have issues? |
n8n
|
Project |
n8n
|
Branch Review |
license-sdk-2_19_0
|
Run status |
|
Run duration | 03m 53s |
Commit |
|
Committer | Cornelius Suermann |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
475
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Technically, yes — this is a breaking change, since users will no longer be able to configure the renewal offset themselves. However, in practice, there was never a strong reason to make this setting configurable in the first place. The default has always been 72 hours, and it's unlikely that many users have changed it. So while it is a breaking change in theory, I don't believe it should be classified or communicated as such in this case. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
✅ All Cypress E2E specs passed |
…rable (#14266) Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Got released with |
Summary
N8N_LICENSE_DETACH_FLOATING_ON_SHUTDOWN
, which can be set tofalse
to prevent entitlements from being detached. Note that thelicense:clear
command will still attempt to detach them.license:clear
command.N8N_LICENSE_AUTO_RENEW_OFFSET
environment variable, replacing it with a fixed renewal offset of 72 hours.Related Linear tickets, Github issues, and Community forum posts
Closes https://linear.app/n8n/issue/CAT-727
Review / Merge checklist
PR Labeled withrelease/backport
(if the PR is an urgent fix that needs to be backported)