fix(core): Return correct trigger count for nodes with multiple webhooks #14300
+82
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
MarcL
force-pushed
the
pay-2146-logic-for-calculating-active-workflows-needs-adjusting-for
branch
from
901aadc to
6f5e6a1
Compare
r00gm
reviewed
Apr 1, 2025
despairblue
reviewed
Apr 1, 2025
MarcL
force-pushed
the
pay-2146-logic-for-calculating-active-workflows-needs-adjusting-for
branch
from
c55137f to
fd53a1e
Compare
|
|
despairblue
force-pushed
the
pay-2146-logic-for-calculating-active-workflows-needs-adjusting-for
branch
from
91a3e38 to
c016f98
Compare
This reverts commit bab8c16.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
…djusting-for' of github.com:n8n-io/n8n into pay-2146-logic-for-calculating-active-workflows-needs-adjusting-for
…flows-needs-adjusting-for
despairblue
approved these changes
Apr 3, 2025
Comment on lines
-49
to
-56
| export async function testVersionedTriggerNode( | ||
| Trigger: new () => VersionedNodeType, | ||
| version?: number, | ||
| options: TestTriggerNodeOptions = {}, | ||
| ) { | ||
| return await testTriggerNode(getNodeVersion(Trigger, version), options); | ||
| } | ||
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2146-logic-for-calculating-active-workflows-needs-adjusting-for
|
| Run status |
|
| Run duration | 03m 37s |
| Commit |
|
| Committer | Marc Littlemore |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
475
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
MarcL
deleted the
pay-2146-logic-for-calculating-active-workflows-needs-adjusting-for
branch
guillaumejacquart
pushed a commit
that referenced
this pull request
Apr 4, 2025
…oks (#14300) Co-authored-by: Danny Martini <danny@n8n.io> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where the workflow trigger count was incorrectly inflated when a single node, such as the Form Trigger, registers multiple webhooks (e.g. a form trigger has a webhook for both HTTP GET and POST methods). We want to count these as a single trigger for the node.
It adds an integration test to confirm we're now writing the correct trigger count to the database.
Related Linear tickets, Github issues, and Community forum posts
Fixes: PAY-2146
Issues: #13820
Review / Merge checklist
[ ] Docs updated or follow-up ticket created.[ ] PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)