Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Node): Add doctype to page #14306

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

michael-radency
Copy link
Contributor

Summary

Added <!DOCTYPE html>

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2641/fix-form-page-doctype

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@dana-gill dana-gill self-requested a review April 1, 2025 07:57
Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the form-trigger-404.handlebars or form-trigger-409.handlebars also need this?

Copy link

cypress bot commented Apr 2, 2025

n8n    Run #10066

Run Properties:  status check passed Passed #10066  •  git commit 84bb9ade67: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2641-fix-form-page-doctype
Run status status check passed Passed #10066
Run duration 04m 20s
Commit git commit 84bb9ade67: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 475
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Apr 2, 2025

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit df9ea09 into master Apr 2, 2025
36 checks passed
@michael-radency michael-radency deleted the node-2641-fix-form-page-doctype branch April 2, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants