feat(HTTP Request Node): Port optimizeResponse from httpRequest tool to standalone node (no-changelog)
#14307
+444
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
CharlieKolb
changed the title
optimizeResponse from httpRequest tool to standalone nodeoptimizeResponse from httpRequest tool to standalone node
CharlieKolb
changed the title
optimizeResponse from httpRequest tool to standalone nodeoptimizeResponse from httpRequest tool to standalone node (no-changelog)
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
netroy
reviewed
Apr 7, 2025
| @@ -870,6 +870,7 @@ | |||
| "@n8n/di": "workspace:*", | |||
| "@n8n/imap": "workspace:*", | |||
| "@n8n/vm2": "3.9.25", | |||
| "@mozilla/readability": "0.5.0", | |||
There was a problem hiding this comment.
we are already using 0.6.0 in the langchain packahe
| }; | ||
| }; | ||
|
|
||
| export const configureResponseOptimizer = (ctx: IExecuteFunctions, itemIndex: number) => { |
There was a problem hiding this comment.
should we add some unit tests for this?
| @@ -1167,6 +1169,10 @@ export const mainProperties: INodeProperties[] = [ | |||
| }, | |||
| ], | |||
| }, | |||
| ...optimizeResponseProperties.map((x) => ({ | |||
There was a problem hiding this comment.
instead of adding these here, we could define a new flag in node descriptions, and when that flag is set, we could add these properties in applySpecialNodeParameters.
That way we can add this as an option on more nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce new tool-only property
optimizeResponsewhich is equivalent to the toolHttpRequest option. Chose to duplicate the code rather than introducing all the dependencies into theworkflowpackage.Note that we'll enable this node as a tool (and hide the old version) in a separate PR after this.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3304/feature-port-optimizeresponse-to-all-nodesastools
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)