Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show correct message on retry #14321

Conversation

michael-radency
Copy link
Contributor

Summary

show message reflecting execution status instead of success/failed

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2508/retry-unsuccessful-error-when-a-retried-execution-is-successfully

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

…retry-unsuccessful-error-when-a-retried-execution-is
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/executions/execution.service.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 1, 2025
@dana-gill dana-gill requested a review from elsmr April 1, 2025 14:45
Copy link
Contributor

github-actions bot commented Apr 2, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Apr 2, 2025

n8n    Run #10069

Run Properties:  status check passed Passed #10069  •  git commit 793eb7ab45: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2508-retry-unsuccessful-error-when-a-retried-execution-is
Run status status check passed Passed #10069
Run duration 03m 46s
Commit git commit 793eb7ab45: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 475
View all changes introduced in this branch ↗︎

…retry-unsuccessful-error-when-a-retried-execution-is
@michael-radency michael-radency requested a review from elsmr April 2, 2025 13:21
Copy link
Contributor

github-actions bot commented Apr 2, 2025

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 501963f into master Apr 2, 2025
36 checks passed
@michael-radency michael-radency deleted the node-2508-retry-unsuccessful-error-when-a-retried-execution-is branch April 2, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants