Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Jira Trigger Node): Fix Jira webhook subscriptions on Jira v10+ #14333

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Apr 1, 2025

Summary

Jira webhook subscription on v10+ use a different endpoint.

  1. Call Jira serverInfo endpoint to get the version
  2. Switch webhook endpoint according to version

Tested locally with Jira 9 and 10

To easily test with different Jira versions: https://hub.docker.com/r/atlassian/jira-software

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2486/update-jira-trigger-node-for-new-webhook-endpoint-jira-10
https://community.n8n.io/t/jira-10-the-url-to-webhook-resource-has-changed-to-jira-url-rest-jira-webhook-1-0-webhook/80066

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
elsmr Elias Meire
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Jira/JiraTrigger.node.ts 78.57% 3 Missing ⚠️
packages/nodes-base/nodes/Jira/GenericFunctions.ts 80.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 1, 2025
elsmr added 2 commits April 2, 2025 10:16

Verified

This commit was signed with the committer’s verified signature.
elsmr Elias Meire
…-webhook-endpoint-jira-10

Verified

This commit was signed with the committer’s verified signature.
elsmr Elias Meire
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Apr 2, 2025

n8n    Run #10056

Run Properties:  status check passed Passed #10056  •  git commit e78eea1092: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-2486-update-jira-trigger-node-for-new-webhook-endpoint-jira-10
Run status status check passed Passed #10056
Run duration 03m 59s
Commit git commit e78eea1092: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 475
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Apr 2, 2025

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit cd212e4 into master Apr 2, 2025
47 checks passed
@ShireenMissi ShireenMissi deleted the node-2486-update-jira-trigger-node-for-new-webhook-endpoint-jira-10 branch April 2, 2025 10:49
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
@janober
Copy link
Member

janober commented Apr 7, 2025

Got released with n8n@1.87.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants