Skip to content

feat(ensadmin): ENS Protocol Inspector Form #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

notrab
Copy link
Member

@notrab notrab commented Apr 14, 2025

This adds a form for when /inspector has no selected strategy or name. Closes #519

@notrab notrab requested a review from a team as a code owner April 14, 2025 12:56
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 36d92ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin.ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 2:54pm
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 2:54pm
ensrainbow.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 2:54pm

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Cool to see this! Shared some copy suggestions

<div className="max-w-lg w-full bg-white p-8 rounded-lg shadow-sm border">
<h2 className="text-2xl font-semibold mb-6">ENS Protocol Inspector</h2>
<p className="mb-6 text-gray-600">
Enter an ENS name and strategy to visualize its resolution process through the ENS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enter an ENS name and strategy to visualize its resolution process through the ENS
Select an ENS protocol inspection strategy and enter an ENS name for a developer-friendly interactive visualization of how the ENS protocol operates.

<h2 className="text-2xl font-semibold mb-6">ENS Protocol Inspector</h2>
<p className="mb-6 text-gray-600">
Enter an ENS name and strategy to visualize its resolution process through the ENS
protocol.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protocol.

return (
<div className="flex flex-col items-center justify-center h-[calc(100vh-6rem)] p-8">
<div className="max-w-lg w-full bg-white p-8 rounded-lg shadow-sm border">
<h2 className="text-2xl font-semibold mb-6">ENS Protocol Inspector</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add one more "teaser" tag on the end of this h2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "teaser" of ENS Protocol Inspector
2 participants