-
Notifications
You must be signed in to change notification settings - Fork 163
feat: Accept kwargs in {DataFrame,Series}.to_pandas
#2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this @dangotbanned , it seems reasonable to me!
Yet if we do it, I would rather keep it consistent for all the dtypes that would only be supported with ArrowDtype's. WDYT?
- Lightly adapted fromhttps://arrow.apache.org/docs/python/generated/pyarrow.Table.html#pyarrow.Table.to_pandas - Most likely, will edit it down but there's too many options + ambiguous names to not have something
Struct
dtype in pyarrow
-> pandas
(DataFrame|Series).to_pandas
No intention of supporting it there
Was causing another test to fail that expected numpy dtypes
Hey @MarcoGorelli, would you be able to give me some boxes to tick in order to get this one over the line please? π It seems like we've been in agreement from the start on But it doesn't seem like the changes I've made in response to (#2879 (comment)) and (#2879 (comment)) have gotten us closer Really appreciate you bearing with me on this! |
What type of PR is this? (check all applicable)
Related issues
pa.Table.to_pandas
Β #2123Series.hist
Β #2839 (comment)pa.Table.to_pandas
Β #2123 (comment))Description
Note
Changed scope a bit from the original PR, see (#2879 (review)) and the original description for details
Show original description
Description
While I was looking into (#2839 (comment)) I noticed that the default (and only) behavior for
nw.DataFrame.to_pandas
when backed by eitherpa.Table
,pl.DataFrame
isn't great for nested datatypes:We can do better than this, and currently this PR will instead give us something that works with
pd.Series.struct
:Questions
DType
s e.g.List
?to_pandas(use_pyarrow_extension_array=...)
parameter frompolars
?i. Note that this defaults to
False
, which is equivalent to our current behavior andpyarrow
'sAdds optional keyword-only arguments to both of
DataFrame.to_pandas
,Series.to_pandas
.This aligns us with the same methods found in
polars
andpyarrow
:polars.Series.to_pandas
pyarrow.ChunkedArray.to_pandas
polars.DataFrame.to_pandas
pyarrow.Table.to_pandas
As mentioned in (#2123), this can reduce the memory overhead if configured correctly.
But, the main benefit I'm excited about is that we can preserve
pyarrow
data types (nulls, nested data) see (#2123 (comment)) - which were previously lost unconditionallyExample
Before
After
Tasks
Compliant*
signaturesCompliant*
runtime behaviorArrow(DataFrame|Series)
Polars(DataFrame|Series)
PandasLike(DataFrame|Series)
cuDF
DataFrame.to_pandas
Series.to_pandas
DataFrame.to_pandas
Series.to_pandas
pyarrow
addedTable.to_struct_array
to_struct_array
compat forpyarrow<15
polars
andpandas
as wellSeries
DataFrame
{DataFrame,Series}.to_pandas
Β #2879 (review))PandasLike
alternatives (feat: Accept kwargs in{DataFrame,Series}.to_pandas
Β #2879 (comment))