Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 bucket name to the output #36

Closed
wants to merge 2 commits into from
Closed

Conversation

thanhz
Copy link

@thanhz thanhz commented Mar 11, 2024

No description provided.

@MancunianSam
Copy link
Contributor

Aren't you just outputting something that you're passing in as a variable? I'm not against it as such but usially the outputs are for things that have been created in the module.

@thanhz
Copy link
Author

thanhz commented Mar 11, 2024

Aren't you just outputting something that you're passing in as a variable? I'm not against it as such but usially the outputs are for things that have been created in the module.

Yeah I thought it was unusual. I saw it being done like this in the tdr-terraform-modules so just replicated that. But yeah seems a bit pointless. Closing the PR as I've modified the other pr to just use the variable directly.

@thanhz thanhz closed this Mar 11, 2024
@thanhz thanhz deleted the add_s3_bucket_name_output branch March 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants