DR2-2007 Remove mgmt terraform roles and use account ones. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deletes the management roles which assumed the roles in the environment accounts and updates the trust policies on those accounts to allow GitHub to run them. It also updates the bucket policy for the state bucket and the resource policy for the lock table.
techncl
reviewed
Dec 4, 2024
| ], | ||
| "Effect": "Allow", | ||
| "Resource": [ | ||
| "arn:aws:s3:::mgmt-dp-terraform-state", |
There was a problem hiding this comment.
Is it fine that we're hardcoding mgmt here and below?
There was a problem hiding this comment.
Yeah, there's only one state bucket and it's in the management account.
| terraform_external_id = module.terraform_config.terraform_config["intg"]["terraform_external_id"] | ||
| terraform_github_role_arn = module.terraform_github_terraform_environments["intg"].role_arn | ||
| management_developer_role_arn = data.aws_ssm_parameter.dev_admin_role.value | ||
| source = "./environment_roles" |
There was a problem hiding this comment.
Should the source be adding to a local variable since it's used 4 times?
There was a problem hiding this comment.
I just tried it, terraform won't let you. A lot of people want it but they say no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the management roles which assumed the roles in the
environment accounts and updates the trust policies on those accounts to
allow GitHub to run them.
It also updates the bucket policy for the state bucket and the resource
policy for the lock table.
This will need nationalarchives/da-terraform-modules#82 to be merged
before this can be deployed.