-
Notifications
You must be signed in to change notification settings - Fork 203
Introduce orjson
as optional dependency
#662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Looks like some dev dependencies require >=py3.9 after I updated the lock file |
Might want to do a Pipfile update + dropping 3.8 in a separate PR Workflows complain about "ModuleNotFoundError: No module named 'tomli'" |
The tests fail with Can anyone help understand how to fix this? cc active contributors: @caspervonb @wallyqs |
Can I please get some help with this? @wallyqs @caspervonb I'd like to contribute some other things to this repo too, so I'm mainly curious what the status of the project is -- are there pending contributions that will address the Pipfile update? |
Signed-off-by: ff137 <ff137@proton.me>
…json` Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
The answer is that I should not have done a Pipfile lock update. Doing so essentially drops py3.8 support. |
Signed-off-by: ff137 <ff137@proton.me>
Success 🎉 @wallyqs @caspervonb sorry for the spam - now just want to say it's ready for review |
Signed-off-by: ff137 <ff137@proton.me>
Previous test failure was intermittent -- everything passes after an empty commit |
Relates to #661
✨ Implements a JsonUtil module to handle the functionality of swapping between
json
ororjson
JsonUtil.dump_bytes
to avoid the numerous instances of encoding and decoding strings unnecessarily (sinceorjson
returns bytes by default)🎨 Replaces
import json
withfrom nats.json_util import JsonUtil as json
➕ Adds
orjson
optional dependency to pyproject.toml and setup.py✅ Updates tests to accommodate changes, and the fact that orjson.dumps does not include spaces.
👷 Add orjson runs to travis jobs (for python 3.11 -> 3.13)