Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signandsendtxs hook returns results #1300

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: signandsendtxs hook returns results #1300

merged 1 commit into from
Mar 6, 2025

Conversation

gagdiez
Copy link
Collaborator

@gagdiez gagdiez commented Feb 13, 2025

Description

Our current signAndSendTransactions hook returns a vector of FinalExecutionOutcome, but people is generally waiting for the actual result

This PR modifies the hook so it returns the result of the Transaction, and not the execution object itself

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@gagdiez gagdiez changed the base branch from main to dev February 13, 2025 13:28
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trechriron trechriron merged commit 98285d1 into dev Mar 6, 2025
7 checks passed
@trechriron trechriron deleted the fix-hook branch March 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants