Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic): only set coc_diagnostic_map on displayByVimDiagnostic #5245

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

fannheyward
Copy link
Member

Closes #5242

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.35%. Comparing base (674482c) to head (9aa7edb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/diagnostic/buffer.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5245      +/-   ##
==========================================
- Coverage   97.36%   97.35%   -0.02%     
==========================================
  Files         291      291              
  Lines       27038    27040       +2     
  Branches     5610     5611       +1     
==========================================
- Hits        26326    26325       -1     
- Misses        495      498       +3     
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit baac60a into master Jan 13, 2025
2 of 4 checks passed
@fannheyward fannheyward deleted the fix/diagnostic-map branch January 13, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] New diagnostic feature seem to pick up vim.diagnostic by default
1 participant