fix(core): prevent stack overflow with snapshot enabled #15526
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most lazy fix I could think of to prevent the stack overflow during search for the next id. It will not help with the ever-increasing registry size and slowness with snapshot enabled in the application until you grab the next snapshot, but it will prevent the stack overflow if the search goes too deep. Feel free to fix it another way if you're dissatisfied with this band-aid. Just wanted to highlight the issue.
Pull Request Test Coverage Report for Build 5701a038-06d9-4ede-b2c1-e14b62c40556Details
💛 - Coveralls |
|
Could you please provide a minimum reproduction repository (Git repository/StackBlitz/CodeSandbox project)? |
|
I'll see if I can find time to make one by the end of this week. |
Hardanish-Singh
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
With snapshot enabled it will use the deterministic UUID generator which in turn will keep track of a registry of currently in use UUIDs. They way it was doing the search for the next available UUID for the input key involved calling itself over and over until it found an available key, which could lead to a stack-overflow.
Issue Number: N/A
What is the new behavior?
The most lazy fix I could think of to prevent the stack overflow during search for the next id was switching the self-recursion out with a while loop. It will not help with the ever-increasing registry size and slowness with snapshot enabled in the application until you grab the next snapshot, but it will prevent the stack overflow as the search won't go as deep as before.
Feel free to fix it another way if you're dissatisfied with this band-aid. Just wanted to highlight the issue.
Does this PR introduce a breaking change?
Other information