Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2115: Updated TE filters (Drawer) #2582

Merged
merged 445 commits into from
Aug 12, 2024
Merged

Conversation

Sun-Mountain
Copy link
Contributor

@Sun-Mountain Sun-Mountain commented Jun 19, 2024

Applying new design for the search results page, where the filters are in a drawer.

The filters are currently broken as this layout is better suited for the filtering to happen in the backend which ill be applied in 1680.

Expected filter behavior is changing the search query changes the search. Changing anything else will result in a different URL.

ChelseaKR and others added 30 commits April 5, 2024 15:26
* enhanced search matching logic
added related trainings to occupation page
1853: Switch ceterm:estimatedDuration to be used for completion time instead of clock hours
@mflymfly
Copy link
Collaborator

1:03 load time when searching for Nurse. Can this be improved?

All

  • Change “Search by training, provider, certification, SOC code, or keyword” > “Search by training, provider, certification, SOC code, CIP code, or keyword”
  • Make filter labels sentence case
  • Need to include filter chips so users know what filters are applied
    • May require a separate / follow up ticket but should not launch without it
      image (4)

Desktop

  • Sticky header and footer of drawer full width

Mobile

  • Filter drawer 95vh max heights
  • Sticky header of drawer full width

@ChelseaKR ChelseaKR self-requested a review August 1, 2024 03:23
@ChelseaKR
Copy link
Collaborator

Reassigning followup to @scwambach

@ChelseaKR ChelseaKR merged commit 4ba67d3 into credential-engine Aug 12, 2024
2 checks passed
@ChelseaKR ChelseaKR deleted the nz/2115-filter-drawer branch August 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants