Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove/upgrade deprecated linters #19

Merged
merged 1 commit into from
May 6, 2024

Conversation

sigilioso
Copy link
Contributor

It removes/upgrades deprecated linters in order to fix warnings/errors in pipelines. Example: nri-kafka

Running [/home/runner/golangci-lint-1.58.0-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-4774-134jry3C6xNz/pull.patch --new=false --new-from-rev=] in [] ...
  level=warning msg="[config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`."
  level=warning msg="[config_reader] The configuration option `linters.gci.local-prefixes` is deprecated, please use `prefix()` inside `linters.gci.sections`."
  level=warning msg="[config_reader] The configuration option `linters.gomnd.settings` is deprecated. Please use the options `linters.gomnd.checks`,`linters.gomnd.ignored-numbers`,`linters.gomnd.ignored-files`,`linters.gomnd.ignored-functions`."
  level=warning msg="[lintersdb] The name \"goerr113\" is deprecated. The linter has been renamed to: err113."
  level=warning msg="The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  level=warning msg="The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd."
  level=error msg="[linters_context] deadcode: This linter is fully inactivated: it will not produce any reports."
  level=warning msg="[runner] Can't run linter goanalysis_metalinter: failed to pre-run gomnd: failed to configure analyzers: settings key \"mnd\" must be valid analyzer name, valid analyzers: [gomnd]"
  level=error msg="Running error: can't run linter goanalysis_metalinter\nfailed to pre-run gomnd: failed to configure analyzers: settings key \"mnd\" must be valid analyzer name, valid analyzers: [gomnd]"
  
  Error: golangci-lint exit with code 3
  Ran golangci-lint in [23](https://github.com/newrelic/nri-kafka/actions/runs/8933006384/job/24621873807?pr=294#step:6:25)09ms

@sigilioso sigilioso requested a review from a team May 6, 2024 09:13
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for taking care!

@sigilioso sigilioso merged commit 2f1cb2f into main May 6, 2024
5 checks passed
@sigilioso sigilioso deleted the chore/update-deprecated-linters branch May 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants