feat: Add overlay between calendar and open simple editor #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GretaD
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6623 +/- ##
============================================
- Coverage 23.17% 22.99% -0.19%
- Complexity 472 475 +3
============================================
Files 250 252 +2
Lines 12020 12117 +97
Branches 2296 2315 +19
============================================
Hits 2786 2786
- Misses 8907 9004 +97
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GretaD
force-pushed
the
add/overlay-simpleeditor
branch
from
ac323d4 to
45ab8d9
Compare
ChristophWurst
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Code looks good as https://github.com/nextcloud/calendar/pull/6623/files?w=1
Signed-off-by: greta <gretadoci@gmail.com>
GretaD
force-pushed
the
add/overlay-simpleeditor
branch
from
ce16078 to
8699a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the editing state has now a overlay, similar to modal or dialog. It closes if you click the close button on the popover. The viewing state stays the same.
fixes #6582
before
after