Skip to content

Commit

Permalink
Fixing slack notification
Browse files Browse the repository at this point in the history
  • Loading branch information
merschformann committed Sep 23, 2024
1 parent 3b634f0 commit 0d7a140
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ jobs:
export PATH=$PATH:~/.nextmv # Make CLI available in non-interactive shell
export SLACK_NOTIFY_PARAM="" # Only notify slack for prod releases
if [ ${{ matrix.environment }} == "prod" ]; then
export SLACK_NOTIFY_PARAM="--slack-url \"${{ secrets.SLACK_URL_MISSION_CONTROL }}\""
export SLACK_NOTIFY_PARAM="--slack-url ${{ secrets.SLACK_URL_MISSION_CONTROL }}"
fi
python main.py \
--apps "${{ env.APPS }}" \
Expand Down
2 changes: 1 addition & 1 deletion .nextmv/release/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def main():
workflow_app=workflow_app,
)

if options.slack_url is not None:
if options.slack_url:
notify_slack(
url=options.slack_url,
app=name,
Expand Down

0 comments on commit 0d7a140

Please sign in to comment.