Use nextmv.Model syntax #87

sebastian-quintero · 2024-12-09T22:13:45Z

The changes appear to be a lot, but really I am changing all python apps to, instead of using this:

    output = solve(input, options)

We now use this:

    model = DecisionModel()
    output = model.solve(input)


class DecisionModel(nextmv.Model):
    def solve(self, input: nextmv.Input) -> nextmv.Output:
        """Solves the given problem and returns the solution."""

We are basically trading the use of the solve function in favor of the DecisionModel declaration with the solve method. Inside the method, where we were doing options.xyz we now do input.options.xyz.

The changes to indentation is what makes this PR bloat up.

merschformann

I skimmed the changes and all looks good. Thanks for the work! 🤗

merschformann · 2024-12-09T22:23:13Z

python-ortools-costflow/main.py

+def validate_skills(input: nextmv.Input) -> Any:
    """Check that each project skill and each worker skill have a skill pair."""

    for project in input.data["projects"]:
        for skill in project["required_skills"]:
            if not any(skill in worker["skills"] for worker in input.data["workers"]):
-                return errorStatusOutput("input_skill_error", input.options)
+                return error_status_output("input_skill_error", input.options)
    for worker in input.data["workers"]:
        for skill in worker["skills"]:
            if not any(skill in project["required_skills"] for project in input.data["projects"]):
-                return errorStatusOutput("input_skill_error", input.options)
+                return error_status_output("input_skill_error", input.options)
    return None


-def errorStatusOutput(status: str, options: nextmv.Options) -> nextmv.Output:
+def error_status_output(status: str, options: nextmv.Options) -> nextmv.Output:


Thanks for aligning the style along the way. ❤️

Use nextmv.Model syntax

34693a7

sebastian-quintero self-assigned this Dec 9, 2024

sebastian-quintero requested review from merschformann, dirkschumacher, cowanwalls, racquesta and nmisek December 9, 2024 22:20

merschformann approved these changes Dec 9, 2024

View reviewed changes

sebastian-quintero merged commit 7f62ad2 into develop Dec 10, 2024
38 checks passed

sebastian-quintero deleted the feature/python-nextmv-model branch December 10, 2024 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use nextmv.Model syntax #87

Use nextmv.Model syntax #87

sebastian-quintero commented Dec 9, 2024 •

edited

Loading

merschformann left a comment

merschformann Dec 9, 2024

Use nextmv.Model syntax #87

Use nextmv.Model syntax #87

Conversation

sebastian-quintero commented Dec 9, 2024 • edited Loading

merschformann left a comment

Choose a reason for hiding this comment

merschformann Dec 9, 2024

Choose a reason for hiding this comment

sebastian-quintero commented Dec 9, 2024 •

edited

Loading