Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4446 Update marketplace apps in Cloud #9

Conversation

sebastian-quintero
Copy link
Member

Description

Adds functionality for pushing an app to the Nextmv Marketplace. If the app_id or marketplace_app_id is empty in the workflow_configuration.yml file, that app will not be pushed to Marketplace.

@sebastian-quintero sebastian-quintero self-assigned this Feb 7, 2024
…6-move-marketplace-app-update-workflow-to-community-apps-repo
…6-move-marketplace-app-update-workflow-to-community-apps-repo
Base automatically changed from feature/eng-4439-release-workflow to develop February 7, 2024 14:16
…o-community-apps-repo' of github.com:nextmv-io/community-apps into feature/eng-4446-move-marketplace-app-update-workflow-to-community-apps-repo
…,knapsack-ortools=v1.2.6,knapsack-pyomo=v1.2.6,nextroute=v1.2.6,order-fulfillment-gosdk=v1.2.6,routing-ortools=v1.2.6,shift-assignment-ortools=v1.2.6,shift-assignment-pyomo=v1.2.6,shift-planning-ortools=v1.2.6,shift-planning-pyomo=v1.2.6,shift-scheduling-gosdk=v1.2.6,xpress=v1.2.6
@cowanwalls cowanwalls self-requested a review February 8, 2024 15:57
…o-community-apps-repo' of github.com:nextmv-io/community-apps into feature/eng-4446-move-marketplace-app-update-workflow-to-community-apps-repo
@@ -0,0 +1 @@
v1.2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set back to initial version after all the testing.

@sebastian-quintero sebastian-quintero marked this pull request as ready for review February 8, 2024 16:28
Copy link
Contributor

@nilsbeck nilsbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, just some questions around debugging

.nextmv/update_apps.py Outdated Show resolved Hide resolved
.nextmv/update_apps.py Show resolved Hide resolved
Copy link
Member

@cowanwalls cowanwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nitpick. Looks good!

.nextmv/update_apps.py Outdated Show resolved Hide resolved
sebastian-quintero and others added 2 commits February 8, 2024 16:27
Co-authored-by: Patrick Walls <cowanwalls@gmail.com>
@sebastian-quintero sebastian-quintero merged commit 2c99dce into develop Feb 9, 2024
11 checks passed
@sebastian-quintero sebastian-quintero deleted the feature/eng-4446-move-marketplace-app-update-workflow-to-community-apps-repo branch February 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants