Fix version update on dirty collection with another property having optimistic-lock false #3632
+36
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incrementing Version on parent entity for a collection change works correctly even with optimistic-lock="false" on another property of the same entity. Call to HasDirtyCollections has a side effect thus must be called independently from the existence of other dirty properties.
fredericDelaporte
changed the title
|
Sorry for the long delay,, LGTM, but why is it another account opening the pull request than the fix author? |
fredericDelaporte
approved these changes
Jan 12, 2025
|
Thanks for your time!
No problem, We are working with a patched version until the fix is officially available.
I mixed up two accounts I need for different purposes. |
|
As a result, the merged commit will have the other account as an author. It seems you need to open a new PR if you want to avoid that. Let us know. |
No need to change that... go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incrementing Version on parent entity for a collection change works correctly even with optimistic-lock="false" on another property of the same entity. Call to HasDirtyCollections has a side effect thus must be called independently from the existence of other dirty properties.
Fixes #3631