Deprecate Double cast #1104
Closed
Deprecate Double cast #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Primarily, this PR is meant as a discussion opener whether such a deprecation is even wanted or deemed too disruptive for package consumers. |
With PHP's `(double)` cast being deprecated and already having only been an alias for the `(float)` cast, introduce `Float_` as a replacement for the `Double` cast.
mttsch
force-pushed
the
deprecate-double-cast
branch
from
9d35f1c to
aa35e9c
Compare
mttsch
commented
Aug 19, 2025
| @@ -36,21 +36,21 @@ array( | |||
| ) | |||
| ) | |||
| 3: Stmt_Expression( | |||
| expr: Expr_Cast_Double( | |||
| expr: Expr_Cast_Float( | |||
There was a problem hiding this comment.
Not sure if this is covered by BC?
|
We can only rename nodes at major version boundaries. I'd suggest filing an issue and we can add it to the 6.0 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PHP's
(double)cast being deprecated and already having only been an alias for the(float)cast, introduceFloat_as a replacement for theDoublecast.