Skip to content

BUG: Fix the non-weighted DWI data serialization #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhlegarreta
Copy link
Contributor

WIP: Re issue
#79

Fixes #79.

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Jan 31, 2025

This only demonstrates the issue; I wrote the code as I spent time investigating the issue, so pushing it here to move forward. Some thinking/discussion is needed to see what convention we follow so that the issue can be addressed properly.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (0866a82) to head (9be0147).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/nifreeze/data/dmri.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
- Coverage   70.58%   46.28%   -24.30%     
===========================================
  Files          21       21               
  Lines        1020     1024        +4     
  Branches      119      119               
===========================================
- Hits          720      474      -246     
- Misses        258      522      +264     
+ Partials       42       28       -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhlegarreta jhlegarreta force-pushed the FixNonDWIWeightedGradientRW branch 2 times, most recently from 815490e to 94513d5 Compare May 3, 2025 16:53
@jhlegarreta jhlegarreta force-pushed the FixNonDWIWeightedGradientRW branch from 94513d5 to 9be0147 Compare May 3, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.dmri has mismatches between reading/writting/representation
1 participant