Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

way-displays: init module #6791

Merged
merged 5 commits into from
Apr 11, 2025
Merged

Conversation

jolars
Copy link
Contributor

@jolars jolars commented Apr 10, 2025

Description

Adds support for a service using way-displays, which is an alternative to kanshi for managing display configurations on wlroots-based wayland compositors.

Closes #6787

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@jolars
Copy link
Contributor Author

jolars commented Apr 10, 2025

If I understand correctly, the error is related to the news file. I'm not quite sure what I did wrong there. Anyone know?

@jolars
Copy link
Contributor Author

jolars commented Apr 10, 2025

If I understand correctly, the error is related to the news file. I'm not quite sure what I did wrong there. Anyone know?

Okay, I may have solved it now. pkgs wasn't inherited if the news nix file was a function, so this failed because of condition = pkgs.stdenv.hostPlatform.isLinux;, with { pkgs, ...}: at the top.

I've included the fix here in this PR, but maybe you'd prefer if I separated it out? @rycee

@jolars jolars force-pushed the service-way-displays branch from 9fff09d to 287e73c Compare April 10, 2025 09:13
@jolars
Copy link
Contributor Author

jolars commented Apr 10, 2025

Thanks for the review, @khaneliman!

@khaneliman khaneliman merged commit f0c69ed into nix-community:master Apr 11, 2025
3 checks passed
@jolars jolars deleted the service-way-displays branch April 12, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program request: way-displays
2 participants