Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli multiple input #67

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

canerakdas
Copy link
Member

Description

With this PR, if the input pattern points to more than one file, we expect it to work for all of them. In the current version, it only produces output for the first file.

Validation

For example, expect the command below to produce output for all markdown files in the api directory;

npx api-docs-tooling -i PATH_TO_NODE/doc/api/*.md -t json-simple -o .

@canerakdas canerakdas requested a review from a team as a code owner August 11, 2024 19:33
@ovflowd
Copy link
Member

ovflowd commented Aug 11, 2024

Sorry, what exactly was not working? For me Im able to have this working with same arguments but -i "/path/to/*.md"

@canerakdas
Copy link
Member Author

canerakdas commented Aug 11, 2024

Sorry, what exactly was not working? For me Im able to have this working with same arguments but -i "/path/to/*.md"

When I check for the main branch, -i "/path/to/*.md" gives me a JSON output of 268 lines containing only addons 🤔

@ovflowd
Copy link
Member

ovflowd commented Aug 11, 2024

For me it work fine when I surround with quotes, but if this PR fixes it let's get it merged :)

@canerakdas
Copy link
Member Author

For me it work fine when I surround with quotes, but if this PR fixes it let's get it merged :)

Since it is a string array containing more than one file, at worst we fixing the input type 😄 Now I get it, it worked for me too when I added double quotes 👀

@ovflowd ovflowd merged commit 0d7127e into nodejs:main Aug 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants