fix: cache: treat cache-control request header case-insensitively #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Apr 2, 2025
| @@ -319,8 +319,9 @@ module.exports = (opts = {}) => { | |||
| return dispatch(opts, handler) | |||
| } | |||
|
|
|||
| const reqCacheControl = opts.headers?.['cache-control'] | |||
| ? parseCacheControlHeader(opts.headers['cache-control']) | |||
| const rawReqCacheControl = normaliseHeaders(opts)['cache-control'] | |||
There was a problem hiding this comment.
For cache hits, normaliseHeaders() will be called three times (here, and in handleResult(), and in makeCacheKey()).
Would it be preferable to do that once? E.g. mutating or recreating opts here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3904
This relates to...
Cache-Controlheader in request #3904Rationale
Changes
Features
N/A
Bug Fixes
Cache-Controlheader in request #3904Breaking Changes and Deprecations
N/A
Status