fix(root): Replace shortid with nanoid #7720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
commit: |
SokratisVidros
commented
Feb 14, 2025
| @@ -149,7 +149,7 @@ export class CreateIntegration { | |||
| const defaultName = | |||
| providers.find((provider) => provider.id === command.providerId)?.displayName ?? providerIdCapitalized; | |||
| const name = command.name ?? defaultName; | |||
| const identifier = command.identifier ?? `${slugify(name)}-${shortid.generate()}`; | |||
| const identifier = command.identifier ?? `${slugify(name)}-${nanoid()}`; | |||
There was a problem hiding this comment.
Maybe we need a longer id here as the default length is 4.
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →
|
merrcury
approved these changes
Feb 14, 2025
| @@ -94,7 +94,6 @@ | |||
| "rrule": "^2.7.2", | |||
| "rxjs": "7.8.1", | |||
| "sanitize-html": "^2.4.0", | |||
| "shortid": "^2.2.16", | |||
| @@ -149,7 +149,7 @@ export class CreateIntegration { | |||
| const defaultName = | |||
| providers.find((provider) => provider.id === command.providerId)?.displayName ?? providerIdCapitalized; | |||
| const name = command.name ?? defaultName; | |||
| const identifier = command.identifier ?? `${slugify(name)}-${shortid.generate()}`; | |||
| const identifier = command.identifier ?? `${slugify(name)}-${nanoid()}`; | |||
There was a problem hiding this comment.
Suggested change
| const identifier = command.identifier ?? `${slugify(name)}-${nanoid()}`; | |
| const identifier = command.identifier ?? `${slugify(name)}-${shortId()}`; |
the default is length of 21
FYI for the future workflow and steps short id we had length of 6 #7029
regardless please use shortId from libs/application-generic/src/utils/generate-id.ts so we will have the same alphabet on our identifiers.
djabarovgeorge
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Looks good to me, we just need to update the last place to use the internal shortId func
SokratisVidros
force-pushed
the
remove_shortid
branch
from
59a7874 to
3cc8299
Compare
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
force-pushed
the
remove_shortid
branch
from
a6472cd to
e88cc98
Compare
SokratisVidros
force-pushed
the
remove_shortid
branch
from
e88cc98 to
9c004d2
Compare
SokratisVidros
force-pushed
the
remove_shortid
branch
from
9c004d2 to
efa448d
Compare
SokratisVidros
force-pushed
the
remove_shortid
branch
from
cb4279e to
f59156d
Compare
Shortid is deprecated and marked as unsafe
SokratisVidros
force-pushed
the
remove_shortid
branch
from
f59156d to
242e813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Shortid is deprecated and marked as unsafe. https://www.npmjs.com/package/shortid
See also https://github.com/novuhq/packages-enterprise/pull/267