-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(widget): add docker container healthcheck for widget web #7953
base: next
Are you sure you want to change the base?
fix(widget): add docker container healthcheck for widget web #7953
Conversation
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
@zettlrobert do we need the same check for all the different containers and not only web? Since I believe the removal of all checks in the pull request #7929 is requiring further consideration. Can we reintroduce this for all the containers? |
@Aaron-Ritter |
if a container is a dependency for an other container it should not be removed. according to the documentation the compose argument none could be applied: https://docs.docker.com/reference/dockerfile/#healthcheck
if a container is a dependency for an other container it should not be removed. according to the documentation the compose argument none could be applied: https://docs.docker.com/reference/dockerfile/#healthcheck
2f10564
to
28b0856
Compare
What changed? Why was the change needed?
The community edition currently was not starting based on removed healthchecks and container dependencies.
Screenshots
Details
I added a simple node script to check if the web server is up and running that should set an example on how healthchecks could be integrated after removing the
curl
dependency has been removed from the base image.Special notes for your reviewer
Ensure that the environment is configured correctly, all ports and variables are set in the .env file.
For testing purposes, build the
novu-web
docker image locally, and exchange the cloud image in the community-compose file for the locally available one.If you want a failing healthcheck you could pass a port that is NOT running in the container to the healthcheck.
In the docker compose-compose.yaml file replace (just local testing)
Spin up the local compose stack