fix(api,framework): Undefined variables parsing #8041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
desiprisg
force-pushed
the
undefined_variables
branch
from
b45d4c9 to
bc6eaf4
Compare
SokratisVidros
approved these changes
Apr 1, 2025
commit: |
desiprisg
force-pushed
the
undefined_variables
branch
from
bc6eaf4 to
3fbe5fd
Compare
desiprisg
force-pushed
the
undefined_variables
branch
from
3fbe5fd to
893b486
Compare
| @@ -20,6 +20,6 @@ const stringifyDataStructureWithSingleQuotes = (value: unknown, spaces: number = | |||
|
|
|||
| return valueEscapedNewLines; | |||
| } else { | |||
| return String(value); | |||
| return value == null ? '' : String(value as unknown); | |||
There was a problem hiding this comment.
I like this shortcut, but because this is very sensitive part i wonder if we should go with the more explicit version "value === null || value === undefined" instead.
What do you think?
There was a problem hiding this comment.
What's different with that version ?
There was a problem hiding this comment.
String(value) when value is undefined returns undefined. Isn't that the reason we started this PR in the first place?
desiprisg
force-pushed
the
undefined_variables
branch
from
893b486 to
5f27209
Compare
desiprisg
force-pushed
the
undefined_variables
branch
from
5f27209 to
184e0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer