feat(api,dashboard): Require either subject or body for in-app #8050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
d42a8bf to
d38d64e
Compare
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
d38d64e to
78c219e
Compare
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
78c219e to
4af57c7
Compare
SokratisVidros
approved these changes
Apr 4, 2025
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
4af57c7 to
14621d0
Compare
desiprisg
commented
Apr 4, 2025
| @@ -23,7 +23,7 @@ const redirectUrlRegex = | |||
|
|
|||
| const redirectZodSchema = z.object({ | |||
| url: z.string().regex(redirectUrlRegex), | |||
| target: z.enum(['_self', '_blank', '_parent', '_top', '_unfencedTop']).default('_blank'), | |||
| target: z.enum(['_self', '_blank', '_parent', '_top', '_unfencedTop']), | |||
There was a problem hiding this comment.
Need to remove this for ajv to work correctly with anyOf. It seemed to be doing nothing anyway, either on creation or update, since placeholder is _self.
There was a problem hiding this comment.
@LetItRock Btw, do you know why this was there in the first place? It didn't seem to play a role in creation.
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
14621d0 to
9921414
Compare
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
d33b0eb to
cd369f3
Compare
desiprisg
changed the title
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
cd369f3 to
a350704
Compare
desiprisg
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
a350704 to
54bc907
Compare
SokratisVidros
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
54bc907 to
871c424
Compare
SokratisVidros
force-pushed
the
nv-5614-require-email-subject-in-email-step
branch
from
871c424 to
5d7e80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer