tests: Add nrf9151dk #109
Merged
tests: Add nrf9151dk #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| working-directory: asset-tracker-template/app | ||
| run: | | ||
| mkdir -p artifacts | ||
| cp overlay-memfault.conf overlay-memfault-att.conf |
There was a problem hiding this comment.
not sure why we are copying memfault overlay, I think this can be removed
There was a problem hiding this comment.
Just to leave the original pristine I think. In case we decide to do something else with it later. Eg build some config with different memfault token / slug / org etc.
|
|
||
| # Asset Tracker Template debug firmware build | ||
|
|
||
| - name: Build nrf91 debug firmware | ||
| - name: Build thingy91x debug firmware |
There was a problem hiding this comment.
should we also build nrf9151dk debug firmware? I dont know really
There was a problem hiding this comment.
Not sure, but we can add later if needed.
|
|
||
| # Self-hosted runner is labeled according to the device it is linked with | ||
| runs-on: ${{ matrix.device }} | ||
| runs-on: cia-trd-${{ matrix.device }} | ||
| environment: ${{ matrix.device }} |
There was a problem hiding this comment.
what is the purpose of environment: ${{ matrix.device }}?
Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
DematteisGiacomo
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.