workflows: fix release cycle #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish 9151dk memfault elf too. Remove bootloader firmwares from release. Remove publishing fw to nrfcloud. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes
- The main purpose of this PR is to update the release workflows by removing the publishing of bootloader firmware to GitHub releases and removing the publishing of firmware to nRF Cloud. Additionally, it includes publishing the 9151dk Memfault ELF file.
- There are no major concerns regarding security or performance with the changes made. However, the removal of the nRF Cloud publishing workflow might affect users relying on that feature.
Verdict:
- Comment: The changes involve removing a significant part of the release process (publishing to nRF Cloud), which might impact users. It would be beneficial to provide more context or documentation on the reasons behind this removal and any alternative solutions for affected users.
Code review performed by OPENAI - gpt-4o.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish 9151dk memfault elf too.
Remove bootloader firmwares from release.
Remove publishing fw to nrfcloud.