tests: on_target: add shell tests #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DematteisGiacomo
temporarily deployed
to
nrf9151dk
GitHub Actions
Inactive
DematteisGiacomo
had a problem deploying
to
thingy91x
GitHub Actions
Failure
Button and cloud shell tests are added. Renamed test_uart_output.py to test_shell.py. Refactored nrfcloud utils. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
DematteisGiacomo
force-pushed
the
shell_testing
branch
from
77db328 to
1196a7b
Compare
DematteisGiacomo
temporarily deployed
to
nrf9151dk
GitHub Actions
Inactive
DematteisGiacomo
temporarily deployed
to
thingy91x
GitHub Actions
Inactive
DematteisGiacomo
temporarily deployed
to
nrf9151dk
GitHub Actions
Inactive
DematteisGiacomo
temporarily deployed
to
thingy91x
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes
- Added new shell tests to verify device operation through UART output.
- Refactored
nrfcloudutilities to consolidateNRFCloudandNRFCloudFOTAclasses, improving code organization and reuse. - Introduced a new
dut_cloudfixture for cloud-related test setups. - Removed redundant
test_network_reconnectand integrated its functionality into the new shell tests.
- No critical concerns identified; changes are primarily additive and refactoring.
Verdict: Approve
- The changes are well-structured and enhance the test suite with additional coverage and improved utility functions.
Code review performed by OPENAI - gpt-4o.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button and cloud shell tests are added.
Renamed test_uart_output.py to test_shell.py.
Refactored nrfcloud utils.