tests: main: Add test cases for FOTA states #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jtguggedal
commented
Mar 25, 2025
jtguggedal
commented
- Add testcases for FOTA states
- Rename check_* helper functions to expect_*
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add testcases for FOTA states - Rename check_* helper functions to expect_* Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
jtguggedal
force-pushed
the
main-fota-testcases
branch
from
718518b to
ee7719d
Compare
There was a problem hiding this comment.
🎯 Core Changes
- The primary goal of this PR is to add test cases for FOTA (Firmware Over-The-Air) states, enhancing the test coverage for the FOTA functionality.
- Introduced new functions to handle FOTA events and integrated them into the existing test framework.
- Renamed existing
check_*functions toexpect_*to better reflect their purpose in verifying expected outcomes.
- No major concerns identified. The changes are primarily additions and renaming for clarity.
- Verdict:
- Approve: The changes are well-structured, improve test coverage, and enhance code clarity with the renaming of functions.
Code review performed by OPENAI - gpt-4o.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.