modules: app: Move shadow_get() to transport module #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes:
- Moved
shadow_get()function from app module to transport module - Simplified app module by removing cloud connectivity logic
- Added trigger channel observation in transport module
None
Verdict: Approve - Clean refactoring that improves code organization by moving cloud-related functionality to the transport module.
Code review performed by ANTHROPIC - claude-3-5-sonnet-20241022.
The shadow_get() function is moved to the transport module to simplify the app module. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
jtguggedal
force-pushed
the
shadow-get-to-transport
branch
from
d3842d9 to
c1bb83c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shadow_get() function is moved to the transport module to simplify the app module.