Sonarcloud fixes #70
Merged
Sonarcloud fixes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtguggedal
force-pushed
the
sonarcloud-fixes-main
branch
from
b182916 to
db0049c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes:
- Improved code quality by adding missing ARG_UNUSED() macros for unused parameters
- Renamed state object structs to be more descriptive (e.g.
s_object->battery_state) - Made state object parameters const where appropriate
- Fixed comment style consistency (// -> /**/)
- Removed redundant parentheses
None
Verdict: Approve - These are safe code quality improvements that make the code more maintainable without changing functionality.
Code review performed by ANTHROPIC - claude-3-5-sonnet-20241022.
Note: Some line comments were omitted due to technical limitations.
This issues was reported by Sonarcloud. Also, change the state variable name to a more descriptive. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Make the battery state struct name more descriptive. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
This issues was reported by Sonarcloud. Change the state variable name to a more descriptive name. Void an unused argument in work handler. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
* Constify pointers to read-only state variable * Make state object name more descriptive Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
* Constify pointers to read-only state variable * Make state object name more descriptive Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Reported by Sonarcloud. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Reported by Sonarcloud. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Reported by Sonarcloud. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Reported by Sonarcloud. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
jtguggedal
force-pushed
the
sonarcloud-fixes-main
branch
from
db0049c to
e2c7b67
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.