modules: Align watchdog configuration and naming #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes:
- Standardized watchdog configuration across all modules
- Renamed configuration options for consistency
- Added build asserts to validate watchdog timeouts
- Improved documentation for watchdog and message processing timeouts
None - Changes improve code consistency and safety
Verdict: Approve - Changes improve code quality and maintainability without introducing risks
Code review performed by ANTHROPIC - claude-3-5-sonnet-20241022.
jtguggedal
force-pushed
the
wdt-align
branch
3 times, most recently
from
a0a3487 to
368bb79
Compare
Align how each module configures watchdog timeouts and the naming of options and variables. Add build asserts where missing to ensure that message processing time is shorter than the watchdog timeout. Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
jtguggedal
force-pushed
the
wdt-align
branch
from
368bb79 to
fee996b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align how each module configures watchdog timeouts and the naming of options and variables. Add build asserts where missing to ensure that message processing time is shorter than the watchdog timeout.