tests: on_target: add memfault test

[DematteisGiacomo]

Add memfault test.
Test check that coredump are uploaded to memfault.

[github-actions]

🎯 Core Changes

• Introduced a new functional test for Memfault integration in the test_memfault.py file. This test verifies that coredumps are correctly uploaded to the Memfault API by simulating a fault and checking for new coredump traces.

⚠️ Concerns

• The test relies on environment variables for configuration, which may not be set in all environments, potentially leading to test failures.
• The test uses a hardcoded timeout value for waiting on coredump uploads, which might not be suitable for all network conditions or environments.

Verdict:

• Comment: The test is a valuable addition for verifying Memfault integration, but there are concerns about the reliance on environment variables and hardcoded timeout values. Consider adding checks for environment variable presence and making the timeout configurable.

---

Code review performed by OPENAI - gpt-4o.

[github-actions]

🎯 Core Changes

• The update focuses on adding a test for Memfault integration, ensuring that coredumps are uploaded correctly to Memfault.

⚠️ Concerns

• Previous concerns about environment variables and hardcoded timeout values remain unaddressed. These issues could lead to test failures in different environments and under varying network conditions.

Verdict:

• Comment: The test is a valuable addition, but it is important to address the concerns regarding environment variable checks and configurable timeout values to ensure robust and flexible test execution.

---

Code review performed by OPENAI - gpt-4o.