tests: nightly: Fix and add more tests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cellular location method priority is no longer right after Wi-Fi, the location library will not combine Wi-Fi and cellular methods. Due to this we need to update the test to not expect a combined location request. Add additional checks to the same test to also verify that the device samples other sensor sources. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
Remove excessive logging in tests Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
DematteisGiacomo
approved these changes
Feb 28, 2025
The test_location.py test was renamed to test_sampling.py to better reflect its purpose. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes
- The primary change in this pull request is the refactoring of the test suite to accommodate changes in the location library's method priority. The test
test_samplingnow replaces the previous location tests, focusing on verifying that the device samples various sensor sources instead of expecting a combined location request. - The
uart.pyutility file has been updated to remove the UART log from the error message in thewait_for_strandwait_for_str_orderedmethods, which could help in reducing the verbosity of error logs.
- The removal of the UART log from error messages might make debugging more challenging if the log contains crucial information for diagnosing issues.
- Verdict:
- Comment: The changes seem to be in line with the updated functionality of the location library and improve the test coverage for sensor sampling. However, the decision to remove the UART log from error messages should be reconsidered, as it may impact debugging efforts.
Code review performed by OPENAI - gpt-4o.
| run_location(t91x_board, hex_file, location_method="GNSS") | ||
|
|
||
| def run_location(t91x_board, hex_file, location_method): | ||
| def test_sampling(t91x_board, hex_file): |
There was a problem hiding this comment.
The refactoring of the test function from location-specific tests to a more general sampling test is appropriate given the changes in the location library. However, ensure that the new test adequately covers all necessary functionality previously tested.
DematteisGiacomo
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cellular location method priority is no longer right after Wi-Fi, the location library will not combine Wi-Fi and cellular methods.
Due to this we need to update the test to not expect a combined location request.
Add additional checks to the same test to also verify that the device samples other sensor sources.