tests: on_target: add pkk test #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPK test with readme badge and html plot. Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>
DematteisGiacomo
force-pushed
the
ppk_test
branch
from
fd98d62 to
5dde2a5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes
- The main purpose of this PR is to introduce a new PPK (Power Profiler Kit) test for the asset-tracker-template project. This includes adding a new test script
test_power.pywhich measures power consumption and generates reports in CSV and HTML formats. - The GitHub Actions workflows have been updated to include the new PPK test. The
target-test.ymlworkflow now supports running tests on multiple devices, including a new deviceppk_thingy91xwhich only runs when the 'slow' marker is specified. - Permissions for the
testjob inbuild-and-target-test.ymlandtarget-test.ymlhave been modified to allow writing to contents.
- The change in permissions from
contents: readtocontents: writein the GitHub Actions workflows could potentially allow unintended modifications to the repository contents if not properly secured.
- Verdict:
- Comment: The changes introduce a useful new test and enhance the CI/CD workflows, but the modification of permissions to allow writing to contents should be reviewed to ensure it does not introduce security risks.
Code review performed by OPENAI - gpt-4o.
| @@ -22,7 +22,7 @@ jobs: | |||
| test: | |||
| permissions: | |||
| actions: read | |||
| contents: read | |||
| contents: write | |||
There was a problem hiding this comment.
Changing permissions from contents: read to contents: write can introduce security risks if not properly managed. Ensure that the workflow is secure and that only trusted code can execute with these permissions.
|
|
||
| # Self-hosted runner is labeled according to the device it is linked with | ||
| runs-on: ${{ matrix.device }} | ||
| name: Target Test - ${{ matrix.device }} | ||
|
|
||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| contents: write |
There was a problem hiding this comment.
Similar to the build-and-target-test.yml, changing permissions from contents: read to contents: write requires careful consideration. Verify that this change is necessary and that appropriate security measures are in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPK test with readme badge and html plot.