Remove the dependency from Github #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update schema to include data previously pulled from github.
Add repoUrl to completely abandon generating the repo url. Remove readme field from the schema. If the maintainers want to add readme they have to do it using docsUrl field.
FilipZajdel
changed the title
kylebonnici
previously approved these changes
Mar 26, 2025
bencefr
reviewed
Mar 27, 2025
| "title": "The Golioth Reference Design template", | ||
| "description": "This starter project is a standalone application that includes databases (both stateful and time-based), Over-the-air update capabilities, settings service, remote procedure calls (RPCs)", | ||
| "kind": "template", | ||
| "tags": ["dfu","lte"], | ||
| "avatar": "https://avatars.githubusercontent.com/u/58146410?s=48&v=4", |
There was a problem hiding this comment.
This is independent issue that I noticed now, these avatar URLs should not contain the search parameters, they should be added (stripped and replaced) by the component rendering them.
VSC-2913
bencefr
previously approved these changes
Mar 27, 2025
bencefr
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are introduced:
Pull all information about addons and organization from the index instead from github.
Add new fields in the schema to get the missing data that were previously fetched from github.
Add support button that displays e-mail and devzone username of the addon's contributor:
Update organizations' index files to align with introduced changes
Disabling telemetry when run in the local environment
Other minor changes such as dependencies update.