Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NCP sample and NCP Host package v3.0.0 #5

Merged

Conversation

AdamZelikNS
Copy link
Contributor

No description provided.

@AdamZelikNS AdamZelikNS requested review from edmont and milewr November 28, 2024 14:13
@AdamZelikNS
Copy link
Contributor Author

AdamZelikNS commented Nov 28, 2024

Still missing some binary stuff (e.g. libncp-dev.a update) but code changes can already be reviewed -it has been corrected

@AdamZelikNS
Copy link
Contributor Author

AdamZelikNS commented Nov 28, 2024

To do:

  • Update libncp-dev.a
    Update samples/ncp/README.rst to .. file removed from this pr
  • Update (optionally?) ncp_host_v3.0.0 adding README, release_notes.rst
  • Add (optionally?) ncp_host_v3.0.0.zip/ncp_fw/ncp.nrf54l15_nrf54l15.hex
  • Check current-speed = ? in nrf54l15dk_nrf54l15_cpuapp.overlay

@edmont edmont requested a review from a team November 28, 2024 14:33
@milewr
Copy link
Collaborator

milewr commented Nov 28, 2024

To do:

  • Update libncp-dev.a
  • Update samples/ncp/README.rst to not mention nRF52, USB, ..
  • Update (optionally?) ncp_host_v3.0.0 adding README, release_notes.rst

README.rst file will be updated by another PR. You can even remove it from this PR.

@AdamZelikNS AdamZelikNS force-pushed the pr/add_ncp_sample_and_host_pkg branch from 39ec82b to 6b6e8fd Compare November 28, 2024 15:19
@AdamZelikNS
Copy link
Contributor Author

samples/ncp/README.rst removed

@AdamZelikNS AdamZelikNS force-pushed the pr/add_ncp_sample_and_host_pkg branch 3 times, most recently from 90b5e5b to 89e6da1 Compare November 29, 2024 13:46
@AdamZelikNS AdamZelikNS marked this pull request as ready for review November 29, 2024 13:48
@AdamZelikNS AdamZelikNS force-pushed the pr/add_ncp_sample_and_host_pkg branch from 89e6da1 to 10d8de2 Compare November 29, 2024 14:22
There is an implementation of zboss_app_main() in the ZBOSS library.
The modification is to use it in NCP mode instead of the previous
stack thread procedure as the latter has become incompatible.

The mentioned implementation has been slightly adapted to nRF5,
hence the update of libncp-dev as well.

Signed-off-by: Adam Zelik <adam.zelik@nordicsemi.no>
@AdamZelikNS AdamZelikNS force-pushed the pr/add_ncp_sample_and_host_pkg branch from 10d8de2 to 9d54f88 Compare December 3, 2024 09:13
@AdamZelikNS
Copy link
Contributor Author

overlay fixed and pr rebased

@edmont please double check if the samples/ncp/boards/nrf54l15dk_nrf54l15_cpuapp.overlay file is correct now. If so, I'll merge

@@ -0,0 +1,17 @@
#
# Copyright (c) 2021 Nordic Semiconductor ASA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For coherence with the other samples, we can update the copyright dates to 2024 in NCP sample files.

@@ -0,0 +1,35 @@
#
# Copyright (c) 2021 Nordic Semiconductor ASA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@@ -0,0 +1,222 @@
/*
* Copyright (c) 2021 Nordic Semiconductor ASA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Add Network Co-processor sample

Signed-off-by: Adam Zelik <adam.zelik@nordicsemi.no>
Add package with ZBOSS R23 NCP Host tool.

Signed-off-by: Adam Zelik <adam.zelik@nordicsemi.no>
@AdamZelikNS AdamZelikNS force-pushed the pr/add_ncp_sample_and_host_pkg branch from 9d54f88 to 4f959c7 Compare December 3, 2024 09:28
@AdamZelikNS AdamZelikNS merged commit f68a51d into nrfconnect:main Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants