Improve TX power docs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
commented
Dec 2, 2024
krish2718
requested review from
bama-nordic,
sachinthegreen,
prsi98 and
srkanordic
bama-nordic
reviewed
Dec 3, 2024
bama-nordic
reviewed
Dec 3, 2024
ioannisg
reviewed
Dec 3, 2024
ioannisg
reviewed
Dec 3, 2024
krish2718
force-pushed
the
tx_power_improvs
branch
from
3f9430f to
494e322
Compare
ioannisg
reviewed
Dec 3, 2024
There was a problem hiding this comment.
@krish2718 i made a pass and added some suggestions that (at least IMHO) may help developers to understand what they need to do :)
Feel free to adopt the suggestions if you agree
krish2718
force-pushed
the
tx_power_improvs
branch
from
494e322 to
05ca392
Compare
ioannisg
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
@krish2718 thanks. Approved, with a minor typo that you can fix and get this merged.
Add a separate section in the porting guide with doxygen docs and link to NCS doc about TX power calcualtion. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
tx_power_improvs
branch
from
05ca392 to
89f43af
Compare
ioannisg
approved these changes
Dec 5, 2024
kspraveeen
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate section in the porting guide with doxygen docs and link to NCS doc about TX power calcualtion.